Awesome, thank you 👍

I will test soon.

I think this is not correct to modify argv passed to main (it might be non-writable memory IIRC).

I added error handling, and to keep things "separate", I moved the code to a main "wrapper". That way, the "main" main (main_scrcpy) always receives argc/argv in UTF-8 as expected. This implementation does not even require argc == wargc, so I removed the check.

Here is a branch: pr3547.

Please review and test if that still works (currently, I could not test on Windows).

I tested and it worked well.

However, I found that the elements in array argv_utf8 forgotten to free.
I slightly added related logic, please check on it.

  for (int i = 0; i < wargc; ++i) {
      free(argv_utf8[i]);
  }

Also in the windows main, the argc does not use and it will cause compiler complains.

../app/src/main.c: In function ‘main’:
../app/src/main.c:89:10: warning: unused parameter ‘argc’ [-Wunused-parameter]
   89 | main(int argc, char *argv[]) {
      |      ~~~~^~~~

Additionally, I saw that you changed __WINDOWS__ to _WIN32 . I discovered that the code base still contains some of __WINDOWS__. Do you want them all taken out? I can change all of them if it is intentional.

However, I found that the elements in array argv_utf8 forgotten to free.

Good catch 👍

Also in the windows main, the argc does not use and it will cause compiler complains.

OK, I added:

    (void) argc;
    (void) argv;

(yes, also argv, which was used mistakenly instead of argv_utf8 in the first version)

Here is a branch: pr3547.2.

Additionally, I saw that you changed __WINDOWS__ to _WIN32

Yes, __WINDOWS__ is a SDL define. Often, we can just use the "native" one _WIN32. Except maybe in icon.c which also uses __APPLE__ (but the windows ifdef can probably be completely removed here, since the workaround seems not to work on Windows anyway #3458).

LGTM in pr3547.2 branch.

👍 merged into dev: 48bb6f2